Skip to content

Stop rooms concurrently instead of in serial #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2025
Merged

Stop rooms concurrently instead of in serial #59

merged 5 commits into from
May 16, 2025

Conversation

@dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented May 16, 2025

Description

Demo

See this terminal output when stopping YRoomManager with 2 YRoom instances:

[I 2025-05-16 09:42:18.869 RtcExtensionApp] Stopping `YRoomManager` and deleting all 2 YRooms.
[I 2025-05-16 09:42:18.870 RtcExtensionApp] Stopping YRoom 'text:file:dc3214c6-938a-4dc4-975b-8d6b16e2b641'.
[I 2025-05-16 09:42:18.875 RtcExtensionApp] Stopping YRoom 'text:file:964eb6ba-8b92-4965-be77-d5b2500e246b'.
[I 2025-05-16 09:42:18.881 RtcExtensionApp] Stopped `self._process_message_queue()` background task for YRoom 'text:file:dc3214c6-938a-4dc4-975b-8d6b16e2b641'.
[I 2025-05-16 09:42:18.881 RtcExtensionApp] Stopped `self._process_scheduled_save()` background task for YRoom 'text:file:dc3214c6-938a-4dc4-975b-8d6b16e2b641'.
[I 2025-05-16 09:42:18.881 RtcExtensionApp] Stopped `self._process_message_queue()` background task for YRoom 'text:file:964eb6ba-8b92-4965-be77-d5b2500e246b'.
[I 2025-05-16 09:42:18.881 RtcExtensionApp] Stopped `self._process_scheduled_save()` background task for YRoom 'text:file:964eb6ba-8b92-4965-be77-d5b2500e246b'.
[I 2025-05-16 09:42:18.886 RtcExtensionApp] Stopped YRoom 'text:file:dc3214c6-938a-4dc4-975b-8d6b16e2b641'.
[I 2025-05-16 09:42:18.888 RtcExtensionApp] Stopped YRoom 'text:file:964eb6ba-8b92-4965-be77-d5b2500e246b'.
[I 2025-05-16 09:42:18.889 RtcExtensionApp] Successfully stopped `YRoomManager` and deleted all 2 YRooms.

Notice how now, the log statements for stopping both rooms are interleaved, demonstrating that the rooms are indeed being stopped concurrently.

@Zsailer Zsailer merged commit f24f551 into jupyter-ai-contrib:main May 16, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlqqq @Zsailer